Update Mapping Request Payload in controller.rst #18522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the Mapping Request Payload work properly, it is necessary to install the phpstan/phpdoc-parser and phpdocumentor/type-resolver components. Otherwise, nested DTOs within an array will not function correctly. To see: /symfony/framework-bundle/DependencyInjection/FrameworkExtension.php
|
Damir, thanks for this contribution. In the file that you mentioned, I can see this: But, can you please link to the code that shows that those dependencies are required for using this feature? I'm not an expert on this so I'd like to double check this before merging your contribution. Thanks! |
|
I apologize for the inaccuracy, these dependencies are necessary if you want to use an array with nested objects. Consider a following situation: class ParentDto
{
/**
* @param NestedDto[] $nested
*/
public function __construct(
public readonly array $nested = []
) {}
}
class NestedDto
{
public function __construct(public string $value) {}
}If you install these 2 packages, $parentDto->nested will become a nested object array NestedDto[], instead of a regular array. |
|
I reworked your PR in #18936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the Mapping Request Payload work properly, it is necessary to install the phpstan/phpdoc-parser and phpdocumentor/type-resolver components. Otherwise, nested DTOs within an array will not function correctly.
To see:
/symfony/framework-bundle/DependencyInjection/FrameworkExtension.php